Fix: Preserve claim_one status update when transaction aborts#14
Draft
kafkasl wants to merge 1 commit into
Draft
Fix: Preserve claim_one status update when transaction aborts#14kafkasl wants to merge 1 commit into
kafkasl wants to merge 1 commit into
Conversation
…nt use from setting status to failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a SQL error aborted the transaction inside
claim_one, the outer transaction was also rolledback, preventing the job row from being marked as
failed.Solution
yield pin a nested savepoint transaction (txn.conn.transaction()) so that inneraborts don't poison the outer transaction
p.evtreflects the final DB stateTesting
Added a test that verifies a job is correctly marked
failedwhen the body raises a SQL error (callinga non-existent function).